Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@Amelia0010
Copy link
Contributor

@Amelia0010 Amelia0010 commented Dec 10, 2019

Intent of your Pull Request

Beating the current record in cargo credits. This achievement will get progressively harder as the record goes higher.

Also added the "duke of ducats" achievement, which is just beating a million credits

I also added the SQL changelog since I forgot to add it last time.

Oh and I also added the misc table to the DB which is essentially just a glorified assoc list

@Amelia0010 Amelia0010 requested a review from AsV9 as a code owner December 10, 2019 17:45
@Reed0506
Copy link

I feel like this achievement would be better if it just had an extremely high credit goal instead of an increasing goal. the QMs who play right when (if) this achievement is merged get it for basically no effort at all whereas down the line it would probably be almost completely impossible and i feel like both of those things are not what achievements are about. This concept would be far better for a leaderboard system.

@alexkar598
Copy link
Member

This has a problem of difficulty being ridiculously easy at first and ridiculously hard, make it a fixed number like 1 million instead

@Amelia0010
Copy link
Contributor Author

I added another achievement, ducat duke, for that. The point of it getting harder and harder is intended, that's how being "the best" works :)

@Amelia0010 Amelia0010 changed the title Adds the cargoking achievement Adds the cargoking and ducatduke achievements Dec 19, 2019
@alexkar598 alexkar598 merged commit eb8bdf8 into master Dec 24, 2019
@alexkar598 alexkar598 deleted the cargoking branch December 25, 2019 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants