Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

readds the ability to become a snail person through genetic meltdown and the chemical agent-s #8642

Merged
alexkar598 merged 8 commits into from
May 28, 2020
Merged

readds the ability to become a snail person through genetic meltdown and the chemical agent-s #8642

alexkar598 merged 8 commits into from
May 28, 2020

Conversation

@boodaliboo
Copy link
Contributor

@boodaliboo boodaliboo commented May 23, 2020

the reason nich made these unavaiable was fixed a while ago

Changelog

🆑
rscadd: readded the ability to become snail
/:cl:

@yogstation13-bot yogstation13-bot added DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game labels May 23, 2020
@boodaliboo boodaliboo changed the title readds the ability to become a snail person through genetic meltdown and the chemical agents readds the ability to become a snail person through genetic meltdown and the chemical agent-s May 23, 2020
Hopekz
Hopekz suggested changes May 23, 2020
View reviewed changes
@Hopekz Hopekz self-assigned this May 23, 2020
@boodaliboo
Copy link
Contributor Author

boodaliboo commented May 23, 2020

nope

Hopekz
Hopekz suggested changes May 23, 2020
View reviewed changes
Copy link
Contributor

@Hopekz Hopekz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pt:2
You re-included the file meaning you need to modify it to our new standards.

To make it compile:
modify line 62
from ADD_TRAIT(src, TRAIT_NODROP) to ADD_TRAIT(src, TRAIT_NODROP, CURSED_ITEM_TRAIT)

Also; please test your PR since you cannot have tested it since it didn't compile.

@boodaliboo
Copy link
Contributor Author

boodaliboo commented May 23, 2020

pt:2
You re-included the file meaning you need to modify it to our new standards.

To make it compile:
modify line 62
from ADD_TRAIT(src, TRAIT_NODROP) to ADD_TRAIT(src, TRAIT_NODROP, CURSED_ITEM_TRAIT)

Also; please test your PR since you cannot have tested it since it didn't compile.

i truthfully thought there would be no reason to test it as it was just commenting out things disabled

@JamieD1 JamieD1 added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label May 23, 2020
@Amelia0010
Copy link
Contributor

Amelia0010 commented May 24, 2020

the reason nich made these unavaiable was fixed a while ago

Please don't lie. The reason I made these unavailable is because snails are bad.

@Hopekz
Copy link
Contributor

Hopekz commented May 26, 2020

Going to let this PR marinate just in-case someone has any additional opinions on if this shouldn't be merged.

@alexkar598 alexkar598 merged commit 50a9f43 into yogstation13:master May 28, 2020
yogstation13-bot added a commit that referenced this pull request May 28, 2020
@yogstation13-bot
Automatic changelog generation #8642 [ci skip]
b886929
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Hopekz Hopekz Hopekz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Hopekz Hopekz

Labels

Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@boodaliboo @Amelia0010 @Hopekz @JamieD1 @yogstation13-bot @alexkar598