Allow fetching total count JobExecution matched by query#117
Merged
yann-eugone merged 4 commits into0.xfrom Jan 8, 2025
Merged
Allow fetching total count JobExecution matched by query#117yann-eugone merged 4 commits into0.xfrom
yann-eugone merged 4 commits into0.xfrom
Conversation
guich25
force-pushed
the
98_allow_to_count_jobexecution_query
branch
13 times, most recently
from
d7e3ec9 to
ebf7b40
Compare
guich25
force-pushed
the
98_allow_to_count_jobexecution_query
branch
from
192be45 to
a4f7ecb
Compare
yann-eugone
force-pushed
the
98_allow_to_count_jobexecution_query
branch
from
a4f7ecb to
ac3efd1
Compare
yann-eugone
force-pushed
the
98_allow_to_count_jobexecution_query
branch
from
6893fc0 to
9bf7a15
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.x #117 +/- ##
=========================================
Coverage 99.72% 99.72%
- Complexity 906 909 +3
=========================================
Files 147 147
Lines 2879 2892 +13
=========================================
+ Hits 2871 2884 +13
Misses 8 8 ☔ View full report in Codecov by Sentry. |
yann-eugone
changed the title
yann-eugone
approved these changes
Jan 8, 2025
Contributor
yann-eugone
left a comment
yann-eugone
left a comment
There was a problem hiding this comment.
I've rebased the code and it now seems to work
Thank you @guich25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #98 for feature request