Fixed checking Symfony custom services from bundle config#134
Merged
yann-eugone merged 3 commits into0.xfrom Jan 9, 2025
Merged
Fixed checking Symfony custom services from bundle config#134yann-eugone merged 3 commits into0.xfrom
yann-eugone merged 3 commits into0.xfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.x #134 +/- ##
=========================================
Coverage 99.72% 99.72%
- Complexity 906 910 +4
=========================================
Files 147 150 +3
Lines 2879 2912 +33
=========================================
+ Hits 2871 2904 +33
Misses 8 8 ☔ View full report in Codecov by Sentry. |
J-Ben87
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding some tests on #123
I realised that it is not possible to check on services definitions inside the bundle extension
Because at this point, the
ContainerBuilderreceived is almost emptyI had to introduce some compiler passes to do that checks
I've changed the extension tests to have more specific tests rather than single test method with too much configuration