Fixed named argument aliases for Job launchers#174
Merged
yann-eugone merged 1 commit into0.xfrom Jul 17, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.x #174 +/- ##
=========================================
Coverage 99.73% 99.73%
Complexity 926 926
=========================================
Files 154 154
Lines 2976 2976
=========================================
Hits 2968 2968
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@Elkawaie what error did you found? |
Contributor
Author
@yann-eugone When i use this configuration yokai_batch:
launcher:
default: messenger
launchers:
messenger: messenger://messenger
simple: simple://simple
service: service://service?service=app.job.priority_messenger_job_launcherAnd when i declare this: public function __construct(
private JobLauncherInterface $serviceJobLauncher,
private JobExecutionIdGeneratorInterface $idGenerator,
private JobExecutionStorageInterface $storage,
private AppSecurity $security,
) {
}
|
Contributor
|
Thank you @Elkawaie |
yann-eugone
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this error, here's a quick fix.