[1,5,0,1,0,1] is frettable

[hyvyys]

I tested the package with just this one combination, and it returned true. Those are some mad skills!

[yomed]

Hi @hyvyys, thanks for checking out the project!

Right now, the heuristics are around whether there are enough fingers and the notes are in the right spots such that it can be fretted/barred (given fingers of any length...). It could be a nice improvement to limit how "wide" the chord can be, maybe based on the part of the neck too. E.g. the chords near the lower frets could only span ~4 frets, while the higher fretted chords could span more than that.

[hyvyys]

Is a really interesting problem. I tried do code this for my chord fingering generator and I noticed that four fret range is playable (supposing those Voldemort fingers) but only when the distribution of fingers is, well, anatomical. They need to go in equal distances and not like 104101 or 404104. Do you consider any single frets pressed *below* a partial barre playable? I.e. is it humane to press a short barre with fingers other than index or index and middle, idk, pinky? śr., 9 paź 2019, 05:29 użytkownik Yoni Medoff <notifications@github.com> napisał:

…

Hi @hyvyys <https://github.com/hyvyys>, thanks for checking out the project! Right now, the heuristics are around whether there are enough fingers and the notes are in the right spots such that it can be fretted/barred (given fingers of any length...). It could be a nice improvement to limit how "wide" the chord can be, maybe based on the part of the neck too. E.g. the chords near the lower frets could only span ~4 frets, while the higher fretted chords could span more than that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AE6ZWLS2WSG2TKRMZKG66DLQNVFYZA5CNFSM4I6RMHW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAWNBUA#issuecomment-539807952>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE6ZWLU4N3QQQ7ON4A7WBF3QNVFYZANCNFSM4I6RMHWQ> .

[yomed]

Right. I think one way to get around the Voldemort finger problem would be to start off categorizing chords into physically possible and physically impossible, and then create a difficulty score associated for those chords that are possible. I think the examples you pointed out are good options for some heuristics. I think that depending on the use case, it may or may not be appropriate to generate chords based on some difficulty threshold. For use cases leaning toward advanced usage, I would consider the pinky finger to be able to barre pretty well.

I had attempted to make some rules around barring, though it's been a while since I've reviewed the logic:

frettable/index.js

Lines 19 to 22 in 64e9018

	// barre if fret number matches where finger is fretted on a previous note
	// but dont barre when:
	// * on top 5 strings and next note in sequence is a lower fret
	// * on 5th note and third group, and last note would create fourth group