Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 40.84% 40.96% +0.12%
==========================================
Files 58 58
Lines 2904 2910 +6
==========================================
+ Hits 1186 1192 +6
Misses 1530 1530
Partials 188 188 ☔ View full report in Codecov by Sentry. |
Contributor
|
Left small suggestion. Few thoughts, as we're shifting the way we approach unused Jobs from just completed ones:
|
doronkg
reviewed
May 23, 2024
doronkg
reviewed
May 23, 2024
doronkg
reviewed
May 23, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a case where A Job has failed and reached it's maximum retries.
This pod should now be considered unused
What this PR does / why we need it?
PR Checklist