Skip to content

test: remove runc skip for seccomp_notify and memory_policy#3445

Merged
saku3 merged 2 commits intoyouki-dev:mainfrom
nayuta723:use-conditional-test
Mar 8, 2026
Merged

test: remove runc skip for seccomp_notify and memory_policy#3445
saku3 merged 2 commits intoyouki-dev:mainfrom
nayuta723:use-conditional-test

Conversation

@nayuta723
Copy link
Copy Markdown
Contributor

@nayuta723 nayuta723 commented Mar 8, 2026

Description

runc now supports both seccomp notify and memory policy:

Remove the skip conditions so these tests run against both youki and runc.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

Fixes #

Additional Context

runc has supported seccomp notify since v1.1.0 (January 2022).
Remove the skip condition so the test runs against both youki and runc.

Signed-off-by: nayuta-ai <nayuta723@gmail.com>
@nayuta723 nayuta723 force-pushed the use-conditional-test branch from 485ec22 to 08658ac Compare March 8, 2026 03:40
@nayuta723 nayuta723 changed the title test(seccomp_notify): use ConditionalTest with is_runtime_runc test(seccomp_notify): remove runc skip as runc supports seccomp notify Mar 8, 2026
Copy link
Copy Markdown
Member

@saku3 saku3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saku3
Copy link
Copy Markdown
Member

saku3 commented Mar 8, 2026

@nayuta723
If the CI is using runc v1.4.0, it looks like the skip in the memory_policy test can also be removed.
https://github.com/youki-dev/youki/blob/main/tests/contest/contest/src/tests/memory_policy/memory_policy_test.rs#L229

Sorry for the additional request, but could you remove it as well?

@nayuta723 nayuta723 changed the title test(seccomp_notify): remove runc skip as runc supports seccomp notify test: remove runc skip Mar 8, 2026
@nayuta723 nayuta723 changed the title test: remove runc skip test: remove runc skip for seccomp_notify and memory_policy Mar 8, 2026
runc has supported memory policy since v1.4.0 (November 2025).
Remove the TODO and skip condition so the tests run against both
youki and runc.

Signed-off-by: nayuta-ai <nayuta723@gmail.com>
@nayuta723 nayuta723 force-pushed the use-conditional-test branch from 2dcded9 to 54dc68e Compare March 8, 2026 05:18
Copy link
Copy Markdown
Member

@saku3 saku3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this as well.

@saku3 saku3 merged commit 313c16c into youki-dev:main Mar 8, 2026
28 checks passed
@github-actions github-actions bot mentioned this pull request Mar 7, 2026
sat0ken pushed a commit to sat0ken/youki that referenced this pull request Mar 17, 2026
…v#3445)

* test(seccomp_notify): remove runc skip as runc supports seccomp notify

runc has supported seccomp notify since v1.1.0 (January 2022).
Remove the skip condition so the test runs against both youki and runc.

Signed-off-by: nayuta-ai <nayuta723@gmail.com>

* test(memory_policy): remove runc skip as runc supports memory policy

runc has supported memory policy since v1.4.0 (November 2025).
Remove the TODO and skip condition so the tests run against both
youki and runc.

Signed-off-by: nayuta-ai <nayuta723@gmail.com>

---------

Signed-off-by: nayuta-ai <nayuta723@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants