refactor: replace deprecated clap derive attributes with command and arg#3466
refactor: replace deprecated clap derive attributes with command and arg#3466yan-ace62 wants to merge 1 commit intoyouki-dev:mainfrom
Conversation
saku3
left a comment
There was a problem hiding this comment.
Thank you for the changes.
Could you please resolve the conflicts?
Could you share the documentation you referred to for the migration, such as the migration guide?
Would you also mind explaining the following points?
- The rationale for splitting
#[clap(...)]into#[arg(...)]and#[command(...)] - The change related to
number_of_values - Why
allow_hyphen_valueswas removed - How you verified the behavior of the changes
Sorry for the many questions.
Updated the CLI definition to use the modern #[command] and #[arg] attributes, as the legacy #[clap] attributes are now deprecated in clap v4. Signed-off-by: Yan Wen <yan_ace62@126.com>
Hi, thanks for the review! I have addressed the conflicts and here are the details regarding the migration and your questions: Migration Documentation:
Please let me know if you have any further questions or if there are other areas I should look into! |
|
Is this a breaking change? |
"This PR is largely not a breaking change, with one potential exception. |
Updated the CLI definition to use the modern #[command] and #[arg] attributes, as the legacy #[clap] attributes are now deprecated in clap v4.
Description
Type of Change
Testing
Related Issues
Fixes #
Additional Context