refactor: Use cargo autoinherit to factorize the dependencies by lu-zero · Pull Request #3477 · youki-dev/youki

lu-zero · 2026-03-30T19:04:38Z

cargo tree is unchanged.

Description

Refactor the dependencies so they versions are in sync across the workspace.

Type of Change

Refactoring (no functional changes)

Testing

I ran cargo tree before and after.

saku3

Thanks for the PR.

In addition to checking cargo tree, could you also verify that the version-up script works correctly?

https://github.com/youki-dev/youki/blob/main/justfile#L203

saku3 · 2026-03-31T11:51:02Z

tests/contest/contest/Cargo.toml

+tracing = { workspace = true, features = ["attributes"] }
+tracing-subscriber = { workspace = true, features = ["json", "env-filter"] }
+regex = { workspace = true }
+clap= { workspace = true, features = ["std", "suggestions", "derive", "cargo", "help", "usage", "error-context"] }


Suggested change

clap= { workspace = true, features = ["std", "suggestions", "derive", "cargo", "help", "usage", "error-context"] }

clap = { workspace = true, features = ["std", "suggestions", "derive", "cargo", "help", "usage", "error-context"] }

saku3 · 2026-03-31T11:51:41Z

crates/youki/Cargo.toml

 [dependencies]
-anyhow = "1.0.102"
-chrono = { version = "0.4", default-features = false, features = ["clock", "serde"] }
+clap= { workspace = true, features = ["std", "suggestions", "derive", "cargo", "help", "usage", "error-context"] }


Suggested change

clap= { workspace = true, features = ["std", "suggestions", "derive", "cargo", "help", "usage", "error-context"] }

clap = { workspace = true, features = ["std", "suggestions", "derive", "cargo", "help", "usage", "error-context"] }

saku3 · 2026-03-31T11:53:51Z

Cargo.toml

+flate2 = "1.1"
+libbpf-sys = "1.6.4"
+libc = "0.2.180"
+liboci-cli = { version = "0.6.0", path = "crates/liboci-cli" }


https://github.com/youki-dev/youki/blob/main/justfile#L203

# MARK: Version is needed for tagpr to run the version-up script above.

Suggested change

liboci-cli = { version = "0.6.0", path = "crates/liboci-cli" }

liboci-cli = { version = "0.6.0", path = "crates/liboci-cli" } # MARK: Version

@lu-zero

Sorry for the multiple comments, but could you address this as well?

Without this change, just version-up will no longer work correctly.

This is required for tagpr to update the version automatically.

saku3 · 2026-03-31T11:59:22Z

crates/youki/Cargo.toml

-tracing = { version = "0.1.44", features = ["attributes"] }
-tracing-subscriber = { version = "0.3.23", features = ["json", "env-filter"] }
-tracing-journald = "0.3.2"
+liboci-cli = { workspace = true } # MARK: Version


# MARK: Version is not needed.

lu-zero · 2026-03-31T20:58:28Z

rebased, changed folded and sorted the version to be last to fit the script.

saku3

Thank you for the update.

Could you also check whether the DCO sign-off is in place?

https://github.com/youki-dev/youki/pull/3477/checks?check_run_id=70048530980

saku3 · 2026-04-08T00:23:25Z

Cargo.toml

@@ -1,7 +0,0 @@
-[workspace]


This file should not be removed.

Without it, neither cargo tree nor the build will work.
It looks like something may have gone wrong during the rebase.

saku3 · 2026-04-08T00:33:03Z

crates/libcgroups/Cargo.toml

+nix = { workspace = true, features = ["signal", "user", "fs"] }
+procfs = { workspace = true }
+pathrs = { workspace = true }
 oci-spec = { version = "~0.9.0", features = ["runtime"] }


It would be good to unify oci-spec as well.

I'd like to settle this here as well. I think ~0.9.0 is fine.

saku3 · 2026-04-11T00:54:20Z

Please also address the comment about # MARK: Version.

saku3 · 2026-04-13T12:23:29Z

The CI should pass once the latest upstream changes are merged in.

Sorry for the extra work, but could you please merge the latest upstream changes?

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

lu-zero · 2026-04-13T12:37:49Z

Every time I have to redo the patch from scratch, luckily it is 90% automated.

saku3 · 2026-04-13T13:14:45Z

I’m sorry, I committed this by mistake.

Would it be possible to remove the following commit?

lu-zero@7ffbee6

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

lu-zero · 2026-04-13T15:34:46Z

Folded in, I hope that's what you have in mind :)

saku3

Thank you very much for your repeated help.

saku3 · 2026-04-13T16:08:46Z

@youki-dev/youki
@youki-dev/youki-reviewers

I think this is a good change that consolidates the dependencies.

I’d appreciate it if you could take a look and check whether I’ve missed anything.

Since changes to Cargo.toml tend to cause rebases more easily, I’d also appreciate it if this could be reviewed with priority.

nayuta723

I've left a few comments, so please take a look when you have a time.

nayuta723 · 2026-04-13T17:06:13Z

Cargo.toml

+crossbeam = "0.8.4"
+env_logger = "0.11"
+errno = "0.3.14"
+fastrand = "2.3.0"


Suggested change

fastrand = "2.3.0"

fastrand = "^2.3.0"

nayuta723 · 2026-04-13T17:24:11Z

tests/contest/contest/Cargo.toml

+thiserror = { workspace = true }
+tracing = { workspace = true, features = ["attributes"] }
+tracing-subscriber = { workspace = true, features = ["json", "env-filter"] }
+regex = { workspace = true }


Suggested change

regex = { workspace = true }

regex = { workspace = true, features = ["std"] }

nayuta723 · 2026-04-13T17:35:19Z

crates/libcgroups/Cargo.toml

+oci-spec = { workspace = true, features = ["proptests", "runtime"] }
+quickcheck = { workspace = true }
+mockall = { workspace = true, features = [] }
+clap = { workspace = true }


Suggested change

clap = { workspace = true }

clap = { workspace = true, features = ["std", "color", "help", "usage", "error-context", "suggestions"] }

ref: https://github.com/clap-rs/clap/blob/v4.5.13/Cargo.toml#L140-L148

saku3 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 31, 2026

saku3 reviewed Mar 31, 2026

View reviewed changes

lu-zero force-pushed the refactor-dependencies branch from c64b721 to b4656cd Compare March 31, 2026 20:58

lu-zero mentioned this pull request Apr 1, 2026

Bump procfs #3473

Draft

9 tasks

lu-zero force-pushed the refactor-dependencies branch from b4656cd to 2ec903f Compare April 6, 2026 05:50

utam0k requested a review from saku3 April 7, 2026 12:37

saku3 reviewed Apr 8, 2026

View reviewed changes

lu-zero force-pushed the refactor-dependencies branch from 2ec903f to 53db457 Compare April 8, 2026 06:14

lu-zero force-pushed the refactor-dependencies branch 5 times, most recently from dd9fefc to 0a59a02 Compare April 12, 2026 06:56

chore: Pin oci-spec 0.9.0

2d6a26a

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

lu-zero force-pushed the refactor-dependencies branch from 0a59a02 to 8db7376 Compare April 13, 2026 12:37

lu-zero force-pushed the refactor-dependencies branch from 7ffbee6 to 8db7376 Compare April 13, 2026 15:33

chore: Refactor the dependencies in the workspace

63110ac

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

lu-zero force-pushed the refactor-dependencies branch from 8db7376 to 63110ac Compare April 13, 2026 15:34

saku3 approved these changes Apr 13, 2026

View reviewed changes

saku3 requested review from a team April 13, 2026 16:05

nayuta723 reviewed Apr 13, 2026

View reviewed changes

	clap= { workspace = true, features = ["std", "suggestions", "derive", "cargo", "help", "usage", "error-context"] }
	clap = { workspace = true, features = ["std", "suggestions", "derive", "cargo", "help", "usage", "error-context"] }

	liboci-cli = { version = "0.6.0", path = "crates/liboci-cli" }
	liboci-cli = { version = "0.6.0", path = "crates/liboci-cli" } # MARK: Version

	regex = { workspace = true }
	regex = { workspace = true, features = ["std"] }

	clap = { workspace = true }
	clap = { workspace = true, features = ["std", "color", "help", "usage", "error-context", "suggestions"] }

Conversation

lu-zero commented Mar 30, 2026

Description

Type of Change

Testing

Uh oh!

saku3 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lu-zero commented Mar 31, 2026

Uh oh!

saku3 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saku3 commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saku3 commented Apr 13, 2026

Uh oh!

lu-zero commented Apr 13, 2026

Uh oh!

saku3 commented Apr 13, 2026

Uh oh!

lu-zero commented Apr 13, 2026

Uh oh!

saku3 left a comment

Choose a reason for hiding this comment

Uh oh!

saku3 commented Apr 13, 2026

Uh oh!

nayuta723 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

saku3 commented Apr 11, 2026 •

edited

Loading

nayuta723 left a comment •

edited

Loading