Remove the windows dependency
#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecton
reviewed
Feb 6, 2025
| let process_creation_flags = PROCESS_CREATION_FLAGS(0); | ||
|
|
||
| // Convert command to a wide string with a null terminator. | ||
| let mut command_wide = command.encode_wide().chain(Some(0)).collect::<Vec<_>>(); |
There was a problem hiding this comment.
It looks like this was 0 terminated string.
I think the 0 at the end is more correct.
There was a problem hiding this comment.
Yeah looks like there should be a NULL (0) at the end:
The maximum length of this string is 32,767 characters, including the Unicode terminating null character. If lpApplicationName is NULL, the module name portion of lpCommandLine is limited to MAX_PATH characters.
cecton
reviewed
Feb 6, 2025
src/lib.rs
Outdated
| }, | ||
| }, | ||
|
|
||
| mod binding; |
cecton
approved these changes
Feb 6, 2025
yozhgoor
added a commit
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.