Skip to content

Bump rubocop dependency to 0.80.0#2029

Merged
wk merged 5 commits intoytti:masterfrom
funzoneq:fix/rubocop
Feb 29, 2020
Merged

Bump rubocop dependency to 0.80.0#2029
wk merged 5 commits intoytti:masterfrom
funzoneq:fix/rubocop

Conversation

@funzoneq
Copy link
Copy Markdown
Contributor

@funzoneq funzoneq commented Feb 5, 2020

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

➜  oxidized git:(master) rubocop --auto-correct
/Users/avermeer/Documents/oxidized/.rubocop.yml: Warning: no department given for StringLiterals.
/Users/avermeer/Documents/oxidized/.rubocop.yml: Warning: no department given for LineLength.
Error: The `Layout/AlignHash` cop has been renamed to `Layout/HashAlignment`.
(obsolete configuration found in .rubocop.yml, please update it)
➜  oxidized git:(fix/rubocop) rubocop -v
0.79.0

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@e028589). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2029   +/-   ##
=========================================
  Coverage          ?   63.32%           
=========================================
  Files             ?       30           
  Lines             ?     1497           
  Branches          ?        0           
=========================================
  Hits              ?      948           
  Misses            ?      549           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e028589...64ea96a. Read the comment docs.

@wk
Copy link
Copy Markdown
Contributor

wk commented Feb 29, 2020

The required version of Rubocop for oxidized is currently at ~> 0.74.0, and the error you are seeing is the result of using a newer version of Rubocop which contains incompatible changes.

I have expanded on your changes to complete the transition from 0.74.0 to 0.80.0.

@wk wk merged commit 564e144 into ytti:master Feb 29, 2020
@wk wk changed the title Fix/rubocop Bump rubocop dependency to 0.80.0 Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants