Strip uptime from 'show version' command in SG220 switches#2042
Merged
wk merged 1 commit intoytti:masterfrom Mar 7, 2020
Merged
Strip uptime from 'show version' command in SG220 switches#2042wk merged 1 commit intoytti:masterfrom
wk merged 1 commit intoytti:masterfrom
Conversation
Strip uptime that is displayed by the 'show version' command in SG220 switches to avoid meaningless diffs, as noted in issue ytti#1148
Codecov Report
@@ Coverage Diff @@
## master #2042 +/- ##
==========================================
+ Coverage 63.19% 63.32% +0.13%
==========================================
Files 30 30
Lines 1497 1497
==========================================
+ Hits 946 948 +2
+ Misses 551 549 -2
Continue to review full report at Codecov.
|
Contributor
|
Thanks! Consider adding a line to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
PR #1473 has solved the login issues for SG220 switches that ciscosmb model has.
In order to completely assimilate SG220 switches there also has to be a solution for the uptime string that causes meaningless diffs. Note that the complete removal of show system command from the ciscosmb model (as per PR #1799) hasn't solved the problem since in SG220 switches the uptime is printed by the show version command.
This should be the last required change to close issue #1148