fortios: Strip cluster uptime even without :remove_secrets#2061
Merged
wk merged 1 commit intoytti:masterfrom Apr 19, 2020
Merged
fortios: Strip cluster uptime even without :remove_secrets#2061wk merged 1 commit intoytti:masterfrom
wk merged 1 commit intoytti:masterfrom
Conversation
This is not a secert but dynamic data that *always* changes between two dumps, thus it should never be included, regardless of the :remove_secrets setting
Contributor
|
Well spotted! Pulling this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Strip cluster uptime from FortiOS dumps even without :remove_secrets
This is not a secert but dynamic data that always changes between two dumps, thus it should never be included, regardless of the :remove_secrets setting