Skip to content

Add basic support for NSX#2068

Merged
wk merged 9 commits intoytti:masterfrom
ac3cloud:nsx
Apr 23, 2020
Merged

Add basic support for NSX#2068
wk merged 9 commits intoytti:masterfrom
ac3cloud:nsx

Conversation

@elmobp
Copy link
Copy Markdown
Contributor

@elmobp elmobp commented Apr 14, 2020

Add support for VMWare NSX, done it two objects configuration of the whole edge it self and firewall level configuration grouped by edge to make it easier to navigate between diff's.

Minor changes required to http input which are reflected in this PR

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 14, 2020

Codecov Report

Merging #2068 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
+ Coverage   63.19%   63.32%   +0.13%     
==========================================
  Files          30       30              
  Lines        1497     1497              
==========================================
+ Hits          946      948       +2     
+ Misses        551      549       -2     
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 19.00% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9720374...0abf96b. Read the comment docs.

@wk
Copy link
Copy Markdown
Contributor

wk commented Apr 19, 2020

This looks pretty good, but could perhaps benefit from a bit of polish to allow others to orient themselves around the enhancements to the http input:

  • Documentation on using the new username, password and headers parameters would be welcome (probably by extending `docs/Ruby-API.md, which currently mentions precious little about the HTTP input as a whole).
  • Not validating certificates within the HTTP input could be a configuration knob, it's not clear if having the non-validating behavior is a reasonable default.
  • A note within the NSX model (or in the model documentation) on the tested version, as well as which endpoint address should be used as node for configuration (Is it the NSX Edge Gateway itself? The NSX Manager? vSphere? vDirector?) may also be prudent.

@elmobp
Copy link
Copy Markdown
Contributor Author

elmobp commented Apr 19, 2020

Hows those changes look?

@wk
Copy link
Copy Markdown
Contributor

wk commented Apr 22, 2020

This looks excellent! Thanks for extending it!

I've created a small PR for the nsx branch of your repository to include these models in the supported models list, once that (or a similar update with your own wording) is in, I think we are ready to pull it into master.

@elmobp
Copy link
Copy Markdown
Contributor Author

elmobp commented Apr 22, 2020

Done sir :)

@wk
Copy link
Copy Markdown
Contributor

wk commented Apr 22, 2020

Great!

I think you may have accidentally overwritten the CHANGELOG.md file with the last commit in this change set. The changelog was extensively reformatted between the time you're opened this PR and now, and the version in this PR includes a frankenfile which is a mashup of both old and new.

I've submitted a PR against the nsx branch of your fork to revert this.

restore frankenchangelog to normalcy
@elmobp
Copy link
Copy Markdown
Contributor Author

elmobp commented Apr 23, 2020

Woops! Merged :)

@wk wk merged commit 76ea706 into ytti:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants