Add basic support for NSX#2068
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2068 +/- ##
==========================================
+ Coverage 63.19% 63.32% +0.13%
==========================================
Files 30 30
Lines 1497 1497
==========================================
+ Hits 946 948 +2
+ Misses 551 549 -2
Continue to review full report at Codecov.
|
|
This looks pretty good, but could perhaps benefit from a bit of polish to allow others to orient themselves around the enhancements to the
|
|
Hows those changes look? |
|
This looks excellent! Thanks for extending it! I've created a small PR for the nsx branch of your repository to include these models in the supported models list, once that (or a similar update with your own wording) is in, I think we are ready to pull it into master. |
mention nsx edge support in os types
|
Done sir :) |
|
Great! I think you may have accidentally overwritten the I've submitted a PR against the nsx branch of your fork to revert this. |
restore frankenchangelog to normalcy
|
Woops! Merged :) |
Add support for VMWare NSX, done it two objects configuration of the whole edge it self and firewall level configuration grouped by edge to make it easier to navigate between diff's.
Minor changes required to http input which are reflected in this PR