making sure that execution of scripts defined in build.json->exec are calling back into the main execution path#117
Merged
caridy merged 1 commit intoyui:masterfrom Mar 11, 2014
Conversation
… calling back into the main execution path
Member
Author
There was a problem hiding this comment.
essentially, this method run the exec script, waits for it to finish, updates the original input of the callee, and execute the callee again, in which case the exec is gone, and shifter can continue the process.
the bug was that the 3rd argument of the callee was not propagated.
Contributor
|
👍, makes sense to me. I wonder why it was missing at the beginning. |
caridy
added a commit
that referenced
this pull request
Mar 11, 2014
Member
Author
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you're using
require('shifter').add()to add new files into the queue to be executed, and you useexec, shifter will exit without continuing the execution of the queue. This patch fix that. Here is an example file: