Inclusion of --build-dir in args breaks recursive walk

[andrewnicols]

I've just updated to the latest build of shifter and tried to build against our code and found that the --recursive argument is now broken. It seems to have been broken since 0.2.16.

When running --recursively, the build directory used to be relative to the src directory, but it is now relative to the location that Shifter is run from.

[andrewnicols]

I think that the breakage is related to #46 (Make the build output directory configurable) which made the build directory configurable but always relative to the CWD.

Obviously having a build directory relative to CWD breaks where you have a distributed set of src directories to build from. I guess if --recursive is specified, then it should continue to be relative.

[andrewnicols]

It seems that there are two ways to fix this:

• setting --build-dir=./ when running; or
• not setting a default build-dir when recursive is true.

[andrewnicols]

Bah - apologies, I misread my build diff, that doesn't do the right thing still.

[andrewnicols]

Sorry - too me a while to work out how to attach a pull request to an existing issue.

[davglass]

I don't think this solves the problem, I'll look into it next week.

[andrewnicols]

I've removed the version number change and repushed - sorry about that.

Let me know if there's anything I can do to help.

Andrew

[andrewnicols]

Hi Dav,

I don't suppose you've had a chance to look at this further?

Cheers,

Andrew