Corresponding fix of tests for yuglify pull request #17#97
Open
leik wants to merge 4 commits intoyui:masterfrom
Open
Corresponding fix of tests for yuglify pull request #17#97leik wants to merge 4 commits intoyui:masterfrom
leik wants to merge 4 commits intoyui:masterfrom
Conversation
Member
|
Something is not right here. I see 3 files changes (all of them build results), which obviously breaks the tests. Are you missing anything as part of the PR? |
Author
|
This is corresponding to the PR yui/yuglify#17, which you need to merge in first before you get this tests fix in. |
Author
|
Can someone please have a look at the yui/yuglify#17, thank you! |
Author
|
yui/yuglify#17 has been updated, this is to fix the yuglify tests hosted in shifter. The build is expected to fail here until yui/yuglify#17 is merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding fix of tests for yuglify pull request yui/yuglify#17.