Conversation
- Standardized skill structure: frontmatter, 6 required sections - Anti-rationalization as core principle (Common Rationalizations table) - Red Flags and Verification checklist requirements - Flow-code specifics: flowctl integration, evidence, phase naming - Writing principles: process > knowledge, specific > general, evidence > assumption - References flow-code-debug as native exemplar Task: fn-136-borrow-agent-skills-patterns-anti.1
- New Phase 2.3 between Phase 2 (Implement) and Phase 2.5 (Verify & Fix) - Checks implementation scope against epic spec for drift - Minor drift noted in evidence, major drift escalated via Spec conflict protocol - Lightweight 30-second gate, not a full re-review Task: fn-136-borrow-agent-skills-patterns-anti.6
Task: fn-136-borrow-agent-skills-patterns-anti.7
- testing-patterns.md: AAA pattern, mock boundaries, Rust test patterns, anti-patterns, prove-it workflow - security-checklist.md: OWASP Top 10, secret scanning, cargo audit, SQL safety, input validation - performance-checklist.md: cargo bench/flamegraph, DB anti-patterns, async/await patterns, tokio runtime Task: fn-136-borrow-agent-skills-patterns-anti.2
- Annotation-based protection: simplify-ignore-start/end markers - Replaces blocks with BLOCK_<hash> placeholders before model reads - Expands placeholders back on edit/write, restores on stop - Supports //, /* */, #, <!-- --> comment styles - Opt-in only via .claude/settings.json (not hooks.json) - Documentation in hooks/SIMPLIFY-IGNORE.md Task: fn-136-borrow-agent-skills-patterns-anti.8
Add Common Rationalizations (table format), Red Flags (observable symptoms), and Verification (checkbox checklists) sections to: - flow-code-plan - flow-code-work - flow-code-impl-review - flow-code-epic-review Follows the pattern established in flow-code-debug SKILL.md. Task: fn-136-borrow-agent-skills-patterns-anti.3
- Detect missing placeholders before expanding (prevents permanent data loss) - Keep original backup pristine (never overwrite with expanded version) - Require comment prefix for annotations (prevents false triggers in strings/docs) - Document disk-state limitation and missing-placeholder safety
- simplify-ignore: re-append missing blocks instead of full backup restore - simplify-ignore: clear cache after fallback so next Read re-establishes state - cross-model-reviewer: align severity schema with flowctl parsers (critical/warning/info)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
flowctl guardpasses (255 tests, lint clean, typecheck clean)flowctl validate --epic fn-136passes🤖 Generated with Claude Code