Conversation
…point [fn-16.3] - CLAUDE.md: flow-code-run is primary, 5 legacy skills marked deprecated - docs/skills.md: added flow-code-run to core skills, deprecated 5 legacy skills - agents/worker.md: updated impl-review references to note pipeline phase system - docs/CODEBASE_MAP.md: added preferred flow-code:run note, deprecated annotations - docs/token-optimization-audit.md: noted deleted skill files Task: fn-16-plugin-consolidation-and-cleanup.3 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…x refs [fn-16] - Replace 5 deprecated skills (plan, work, plan-review, impl-review, epic-review) with thin redirects to flow-code-run - Delete supporting files (phases.md, steps.md, workflow.md, examples.md) - Update 5 command files to route through flow-code-run - Delete 23 codex/agents/*.toml duplicates (agents/*.md is single source) - Delete codex/skills/ config.env duplicates - Annotate config.env templates with flowctl config equivalents - Update CLAUDE.md, docs/skills.md, agents/worker.md, docs/CODEBASE_MAP.md, docs/token-optimization-audit.md to show flow-code-run as primary Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR consolidates the Flow-Code workflow around /flow-code:run by deprecating legacy skills, removing duplicated Codex agent configs, and updating docs/commands to reflect the unified pipeline.
Changes:
- Deprecated legacy plan/work/review skills and removed their large workflow markdown companions to reduce token overhead.
- Removed duplicated Codex
.tomlagent configs in favor ofagents/*.mdas the source of truth. - Repointed legacy commands and documentation to the unified
/flow-code:runpipeline and updated config.env templates with additional guidance comments.
Reviewed changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/flow-code-work/SKILL.md | Replaced full skill content with deprecation notice pointing to /flow-code:run. |
| skills/flow-code-work/phases.md | Deleted legacy workflow phase documentation. |
| skills/flow-code-ralph-init/templates/config.env | Added config hierarchy + flowctl equivalence comments. |
| skills/flow-code-plan/steps.md | Deleted legacy plan steps documentation. |
| skills/flow-code-plan/SKILL.md | Replaced full skill content with deprecation notice pointing to /flow-code:run. |
| skills/flow-code-plan/examples.md | Deleted legacy plan examples. |
| skills/flow-code-plan-review/workflow.md | Deleted legacy plan-review workflow documentation. |
| skills/flow-code-plan-review/SKILL.md | Replaced full skill content with deprecation notice pointing to /flow-code:run. |
| skills/flow-code-impl-review/workflow.md | Deleted legacy impl-review workflow documentation. |
| skills/flow-code-impl-review/SKILL.md | Replaced full skill content with deprecation notice pointing to /flow-code:run. |
| skills/flow-code-epic-review/workflow.md | Deleted legacy epic-review workflow documentation. |
| skills/flow-code-epic-review/SKILL.md | Replaced full skill content with deprecation notice pointing to /flow-code:run. |
| skills/flow-code-auto-improve/templates/config.env | Added config hierarchy guidance comments. |
| docs/token-optimization-audit.md | Updated audit notes to reflect deleted legacy files. |
| docs/skills.md | Updated “core skills” and usage guidance to emphasize /flow-code:run and mark legacy commands deprecated. |
| docs/CODEBASE_MAP.md | Annotated diagrams/docs to prefer /flow-code:run and mark legacy commands deprecated. |
| commands/flow-code/work.md | Repointed /flow-code:work command stub to call flow-code-run. |
| commands/flow-code/plan.md | Repointed /flow-code:plan command stub to call flow-code-run. |
| commands/flow-code/plan-review.md | Repointed /flow-code:plan-review command stub to call flow-code-run. |
| commands/flow-code/impl-review.md | Repointed /flow-code:impl-review command stub to call flow-code-run. |
| commands/flow-code/epic-review.md | Repointed /flow-code:epic-review command stub to call flow-code-run. |
| codex/skills/flow-code-ralph-init/templates/config.env | Removed duplicated Codex template. |
| codex/skills/flow-code-auto-improve/templates/config.env | Removed duplicated Codex template. |
| codex/agents/workflow-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/worker.toml | Removed duplicated Codex agent config. |
| codex/agents/tooling-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/testing-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/security-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/repo-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/quality-auditor.toml | Removed duplicated Codex agent config. |
| codex/agents/practice-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/plan-sync.toml | Removed duplicated Codex agent config. |
| codex/agents/observability-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/memory-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/github-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/flow-gap-analyst.toml | Removed duplicated Codex agent config. |
| codex/agents/epic-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/epic-auditor.toml | Removed duplicated Codex agent config. |
| codex/agents/env-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/docs-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/docs-gap-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/cross-model-reviewer.toml | Removed duplicated Codex agent config. |
| codex/agents/context-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/capability-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/build-scout.toml | Removed duplicated Codex agent config. |
| codex/agents/agents-md-scout.toml | Removed duplicated Codex agent config. |
| CLAUDE.md | Updated documentation to emphasize /flow-code:run and mark legacy skills deprecated. |
| agents/worker.md | Updated worker guidance around how impl-review is invoked in the new system. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # | ||
| # ── Config Hierarchy ────────────────────────────────────────── | ||
| # Priority: flowctl config > environment variable > this file's default | ||
| # Run `flowctl config show` to see current settings. | ||
| # ────────────────────────────────────────────────────────────── |
There was a problem hiding this comment.
The config hierarchy comment is inaccurate: ralph.sh sources config.env (exporting variables) before applying defaults, so values in this file override any pre-set environment variables rather than the other way around. Also flowctl config show reflects .flow/config.json, not these ralph.sh variables. Please update the comment to match actual precedence (and, if desired, mention that CLI flags like --config/--watch override config.env).
| # | ||
| # ── Config Hierarchy ────────────────────────────────────────── | ||
| # Priority: flowctl config > environment variable > this file's default | ||
| # Run `flowctl config show` to see current settings. | ||
| # ────────────────────────────────────────────────────────────── |
There was a problem hiding this comment.
The config hierarchy comment is inaccurate: auto-improve.sh sources config.env (exporting variables) before applying defaults, so values in this file override any pre-set environment variables rather than the other way around. Also flowctl config show reflects .flow/config.json, not these auto-improve variables. Please update the comment to match actual precedence (and optionally note that CLI flags override config.env).
| **User request:** $ARGUMENTS | ||
|
|
||
| Pass the arguments to the skill. The skill handles the review logic. | ||
| Pass the user request to the skill. The skill handles all pipeline logic. |
There was a problem hiding this comment.
Routing /flow-code:plan-review to flow-code-run without any phase/stop instruction changes the command’s advertised behavior: flowctl phase done will advance linearly from plan_review into work, so invoking plan-review may unexpectedly continue execution beyond review. This also drops support for plan-review-specific arguments (e.g. focus areas / --review=export). Consider either keeping this command calling the legacy skill, or passing an explicit phase-only/stop-after directive to flow-code-run so it performs only the plan review and then returns without advancing into later phases unless explicitly requested.
| Pass the user request to the skill. The skill handles all pipeline logic. | |
| Pass the user request to the flow-code-run skill, but explicitly constrain it to the `plan_review` phase only. | |
| Instruct the skill to stop and return immediately after completing `plan_review`, and not advance into `work` or any later phase unless the user explicitly requests that. | |
| Preserve and honor all plan-review-specific arguments from the user request, including `--review=rp|codex|export` and any focus areas. |
| **User request:** $ARGUMENTS | ||
|
|
||
| Pass the arguments to the skill. The skill handles the review logic. | ||
| Pass the user request to the skill. The skill handles all pipeline logic. |
There was a problem hiding this comment.
Routing /flow-code:impl-review to flow-code-run without any phase/stop instruction changes the command’s advertised behavior: the pipeline phases are linear, so a run-driven impl-review can advance into close (or earlier phases if pipeline state is behind) rather than doing a scoped implementation review only. This also removes impl-review-specific arguments/semantics from the prompt. Consider keeping this command calling the legacy skill, or explicitly instruct flow-code-run to execute only the impl-review phase and then return without advancing further unless explicitly requested.
| Pass the user request to the skill. The skill handles all pipeline logic. | |
| Pass the user request to the skill, but preserve this command's advertised behavior: | |
| - Execute only the `impl-review` phase. | |
| - Treat `$ARGUMENTS` as the implementation review request, including any `--review=rp|codex|export` option and focus areas. | |
| - Do not advance to `close` or any other phase before or after `impl-review` unless the user explicitly requests that. | |
| - After completing the `impl-review` phase, return the review result immediately. |
| **User request:** $ARGUMENTS | ||
|
|
||
| Pass the arguments to the skill. The skill handles the review logic. | ||
| Pass the user request to the skill. The skill handles all pipeline logic. |
There was a problem hiding this comment.
Routing /flow-code:epic-review to flow-code-run without any phase/stop instruction changes the command’s advertised behavior: flow-code-run drives the entire pipeline, so an epic-review invocation may start/continue other phases rather than performing completion review only. Consider keeping this command calling the legacy skill, or explicitly instruct flow-code-run to run only the completion-review/close portion and then return.
| Pass the user request to the skill. The skill handles all pipeline logic. | |
| Pass the user request to the skill, but explicitly constrain it to the epic completion-review/close portion only. | |
| Do not allow flow-code-run to start, resume, or advance any other pipeline phases. | |
| After completing the completion review and close-out behavior, return immediately. |
| **If REVIEW_MODE is `rp` or `codex`, you MUST invoke impl-review and receive SHIP before proceeding.** | ||
|
|
||
| Use the Skill tool to invoke impl-review (NOT flowctl directly): | ||
| Invoke impl-review via the pipeline phase system (NOT flowctl directly). The review phase is handled automatically by `flowctl worker-phase next` when REVIEW_MODE is set. If invoked manually: | ||
|
|
||
| ``` | ||
| /flow-code:impl-review <TASK_ID> --base $BASE_COMMIT | ||
| ``` | ||
|
|
||
| The skill handles everything: | ||
| The review phase handles everything: |
There was a problem hiding this comment.
This section now refers to a “pipeline phase system” and implies the review phase is automatically included when REVIEW_MODE is set. In flowctl, task review is driven by flowctl worker-phase next only when it is invoked with --review <rp|codex> (and it’s distinct from epic-level flowctl phase next/done). Please clarify the terminology and conditions so workers know they must pass the review backend flag (and that this is worker-phase, not pipeline-phase).
| # IMPORTANT: This command MUST invoke the skill flow-code-run | ||
|
|
||
| The ONLY purpose of this command is to call the `flow-code-work` skill. You MUST use that skill now. | ||
| The ONLY purpose of this command is to call the flow-code-run skill. You MUST use that skill now. | ||
|
|
||
| **User input:** $ARGUMENTS | ||
| **User request:** $ARGUMENTS | ||
|
|
||
| Pass the user input to the skill. The skill handles all execution logic. | ||
| Pass the user request to the skill. The skill handles all pipeline logic. |
There was a problem hiding this comment.
/flow-code:work advertises flags like --tdd / --interactive, but this stub now forwards the request to flow-code-run without indicating how those flags should influence the pipeline (and skills/flow-code-run/SKILL.md currently only documents --plan-only). If flow-code-run doesn’t parse/handle these flags, this change will silently break existing usage. Consider documenting/supporting these flags in flow-code-run, or preserving the legacy flow-code-work behavior for this command until parity is confirmed.
| Legacy individual commands (deprecated, still functional): | ||
| 3a. `/flow-code:plan "description"` → 4. `/flow-code:plan-review` → 5. `/flow-code:work <epic-id>` → 6. `/flow-code:impl-review` → 7. `/flow-code:epic-review` |
There was a problem hiding this comment.
The “Legacy individual commands” sequence implies these commands still behave as separate steps (plan → plan-review → work → impl-review → epic-review). However, the updated command stubs route plan-review/impl-review/epic-review through flow-code-run, whose pipeline phases advance linearly; without an explicit stop-after/phase-only mechanism, invoking one of these commands may continue into subsequent phases rather than acting as a single step. Please either update this doc to reflect the new behavior, or ensure the legacy commands truly stop at the intended phase.
Summary
flow-code-run(-6,319 lines)flow-code-runTest plan
🤖 Generated with Claude Code