fix: Fix tag order from git tag function.#30
Merged
zachdaniel merged 2 commits intozachdaniel:masterfrom Feb 20, 2020
Merged
Conversation
This list of tags comes in ABC sorted according to git, whereas last_valid_non_rc_version function assumed it would come in tag revision order. This manifests itself in finding e.g. 9.9.0 as the latest revision when 10.0.0 is in the list of tags, as well. Because this tag is used later to calculate the diff, it winds up double counting commits and therefor doing bumps it should not be.
Pull Request Test Coverage Report for Build 108
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This list of tags comes in ABC sorted according to git, whereas the
last_valid_non_rc_versionfunction assumed it would come in tagrevision order. This manifests itself in finding e.g. 9.9.0 as the
latest revision when 10.0.0 is in the list of tags, as well. Because
this tag is used later to calculate the diff, it winds up double
counting commits and therefore doing bumps it should not be.