Skip to content

Drop support for traffic management via Ingresses#194

Merged
muaazsaleem merged 3 commits into
masterfrom
drop-ingress-traffic
Aug 19, 2020
Merged

Drop support for traffic management via Ingresses#194
muaazsaleem merged 3 commits into
masterfrom
drop-ingress-traffic

Conversation

@aermakov-zalando
Copy link
Copy Markdown
Contributor

We've migrated to stackset-based traffic management and don't intend to migrate back. Let's just drop the unnecessary code.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 24, 2020

Pull Request Test Coverage Report for Build 1618

  • 21 of 23 (91.3%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+3.3%) to 72.119%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/core/types.go 17 19 89.47%
Files with Coverage Reduction New Missed Lines %
pkg/core/types.go 3 87.43%
Totals Coverage Status
Change from base Build 1597: 3.3%
Covered Lines: 1521
Relevant Lines: 2109

💛 - Coveralls

@aermakov-zalando aermakov-zalando changed the title Drop support for traffic management via Ingresses [WIP] Drop support for traffic management via Ingresses Jan 24, 2020
@aermakov-zalando aermakov-zalando force-pushed the drop-ingress-traffic branch 2 times, most recently from 9bd63f6 to ee9708a Compare February 27, 2020 14:54
@mikkeloscar mikkeloscar force-pushed the drop-ingress-traffic branch from ee9708a to f71c0fa Compare August 17, 2020 16:26
aermakov-zalando and others added 2 commits August 17, 2020 18:30
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
@mikkeloscar mikkeloscar force-pushed the drop-ingress-traffic branch from f71c0fa to f4526a6 Compare August 17, 2020 16:30
@mikkeloscar mikkeloscar changed the title [WIP] Drop support for traffic management via Ingresses Drop support for traffic management via Ingresses Aug 18, 2020
@mikkeloscar mikkeloscar mentioned this pull request Aug 19, 2020
@muaazsaleem
Copy link
Copy Markdown
Contributor

👍

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
@mikkeloscar
Copy link
Copy Markdown
Contributor

FYI: I changed the version bump from v2.0 to v1.3 i.e. just bumping the minor version. I think this is the right way because while I understand that we change the API a bit, we're not doing major changes overall to StackSet which would prompt a v2 in my mind.

@mikkeloscar
Copy link
Copy Markdown
Contributor

👍

1 similar comment
@muaazsaleem
Copy link
Copy Markdown
Contributor

👍

@muaazsaleem muaazsaleem merged commit 44eb70c into master Aug 19, 2020
@muaazsaleem muaazsaleem deleted the drop-ingress-traffic branch August 19, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants