Status should not be required in stacks#211
Merged
Merged
Conversation
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
Contributor
Author
|
👍 |
Pull Request Test Coverage Report for Build 1500
💛 - Coveralls |
Contributor
|
👍 |
thilp
added a commit
that referenced
this pull request
Mar 30, 2020
Just like in #211 for Stack, I don't think StackSet.status should be required on creation.
mikkeloscar
pushed a commit
that referenced
this pull request
Mar 31, 2020
Just like in #211 for Stack, I don't think StackSet.status should be required on creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid having Status required as it breaks when deploying a resource without the status defined as the stackset controller does when initially creating stacks.