crd: require unique hosts#613
Merged
mikkeloscar merged 1 commit intoApr 11, 2024
Merged
Conversation
Contributor
Author
|
I've also noticed errors produced by controller-gen, see #580 (comment) |
Contributor
|
@AlexanderYastrebov lgtm, just want to ensure that you are communicating this to users before we roll it out. |
Contributor
|
👍 |
AlexanderYastrebov
force-pushed
the
crd-unique-hosts
branch
from
af1642e to
2eaff4a
Compare
Require unique non-empty hosts for ingress and routegroup specs. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
crd-unique-hosts
branch
from
2eaff4a to
4174f02
Compare
Contributor
Author
|
@mikkeloscar Could you please re-approve, I think we are ready to proceed. |
Contributor
Author
|
👍 |
1 similar comment
Contributor
|
👍 |
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
See zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Note also that #7179 added configMap fields that are not part of origin CRDs yet. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Note also that #7179 added configMap fields that are not part of origin CRDs yet. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Note also that #7179 added configMap fields that are not part of origin CRDs yet. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 12, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 12, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 12, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require unique non-empty hosts for ingress and routegroup specs.