Enable cookies on WebClient.#3
Open
binarymist wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hi, Thanks for the pull request. It took me a little while to get around this pull request.
It seems like in order to support this method ClientApi.PostToUrl (and also send some cookie information along the request) we need to restructure the IWebClient interface rather than directly modifying the SystemWebClient class. |
Author
|
I no longer have access to this .NET environment, and because it's been so long, is no longer fresh in my head. I've passed this onto my client that I was working for at the time. My client will hopefully provide feedback soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If ClientApi.PostToUrl is not generic enough for main stream consumption, consumers could make an extension method out of it.
Access to the WebClient's headers are required in ClientApi.PostToUrl
Currently consumers have to maintain this locally. Once this is included, consumers can then depend on the NuGet package instead.