Skip to content

Support Python 3.7 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alimanfoo merged 4 commits into from
Nov 6, 2018
Merged

Support Python 3.7 #92

alimanfoo merged 4 commits into from
Nov 6, 2018

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Nov 2, 2018

Adds Python 3.7 support.

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py36 passes locally
  • tox -e py27 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@jakirkham jakirkham changed the title WIP: Support Python 3.7 Support Python 3.7 Nov 2, 2018
@jakirkham jakirkham requested a review from alimanfoo November 2, 2018 17:14
@jakirkham
Copy link
Member Author

jakirkham commented Nov 5, 2018

Thoughts on this?

alimanfoo
alimanfoo approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@alimanfoo alimanfoo added this to the 0.6.0 milestone Nov 6, 2018
@alimanfoo alimanfoo mentioned this pull request Nov 6, 2018
Merged
8 tasks
@alimanfoo alimanfoo merged commit 932a912 into zarr-developers:master Nov 6, 2018
@jakirkham jakirkham deleted the support_py37 branch November 6, 2018 16:29
@alimanfoo alimanfoo mentioned this pull request Nov 14, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alimanfoo alimanfoo alimanfoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jakirkham @alimanfoo