Fix missing case to fully revert change to default write_empty_chunks.

[tomwhite]

Fix issue identified in #1001 (comment). I have manually tested this change with:

>>> import zarr
>>> zarr.__version__
'2.11.2'
>>> a = zarr.create((100, 100), chunks=(100, 50), dtype="i4", store="example.zarr")
>>> a[:] = 0
>>> import os
>>> os.listdir("example.zarr")
['.zarray', '0.0', '0.1']

TODO:

• Add unit tests and/or doctests in docstrings
• Add docstrings and API docs for any new/modified user-facing classes and functions
• New/modified features documented in docs/tutorial.rst
• Changes documented in docs/release.rst
• GitHub Actions have all passed
• Test coverage is 100% (Codecov passes)

[jakirkham]

Thanks Tom! 😄

What is the result of git --no-pager grep 'write_empty_chunks=False'?

[tomwhite]

Thanks Tom! 😄

What is the result of git --no-pager grep 'write_empty_chunks=False'?

Docs and tests - so looks good to me!

docs/tutorial.rst:When creating an array with ``write_empty_chunks=False``, 
docs/tutorial.rst:    write_empty_chunks=False:
zarr/tests/test_core.py:        z = self.create_array(shape=(), dtype=a.dtype, fill_value=0, write_empty_chunks=False)
zarr/tests/test_core.py:                              write_empty_chunks=False)

[joshmoore]

👍 thanks all. Doing a quick 2.11.3 release before 🛏️, but I'll add:

1. I knew we should have made the default a constant!
2. During the community call, @d-v-b offered to open a follow-on PR (post-2.11.3) to propose an "auto" setting for write_empty_chunks.

[jakirkham]

Yeah should have checked git grep before 🤦‍♂️

Anyways this is now being added to conda-forge too ( conda-forge/zarr-feedstock#61 ). Thanks for kicking this off Josh and Tom for the PR 🙏

[joshmoore]

Yeah should have checked git grep before 🤦‍♂️

I realized while trying to forward port this to master that I introduced this in #1002 since the diff had an extra newline! So we would have needed to re-grep #1002!

Mea culpa!

[tomwhite]

Thanks @joshmoore - 2.11.3 seems to be working now!

[joshmoore]

whew 😓