2.13.1: generate fixture/meta in conda tests#1143
Merged
joshmoore merged 4 commits intozarr-developers:mainfrom Sep 26, 2022
Merged
2.13.1: generate fixture/meta in conda tests#1143joshmoore merged 4 commits intozarr-developers:mainfrom
joshmoore merged 4 commits intozarr-developers:mainfrom
Conversation
Following the pattern from zarr-developers#824, this generates the fixture test if it does not exist so that tests will pass on conda-forge. see: conda-forge/zarr-feedstock#65
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #1143 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 36 36
Lines 14115 14112 -3
==========================================
- Hits 14108 14105 -3
Misses 7 7
|
Member
Author
|
Argh Still failing ... conda-forge/zarr-feedstock#66 |
joshmoore
added a commit
to joshmoore/zarr-python
that referenced
this pull request
Sep 27, 2022
See description in zarr-developers#1143 Testing locally, however, does not suffice. In this case, the relative path in the test worked for me, but doesn't work on conda-forge. The only reliable way to be sure is to run `./build-locally.py` in the zarr-feedstock **against pre-tagged code**.
6 tasks
joshmoore
added a commit
that referenced
this pull request
Sep 27, 2022
See description in #1143 Testing locally, however, does not suffice. In this case, the relative path in the test worked for me, but doesn't work on conda-forge. The only reliable way to be sure is to run `./build-locally.py` in the zarr-feedstock **against pre-tagged code**.
enthusiastdev121
added a commit
to enthusiastdev121/zarr-python
that referenced
this pull request
Aug 19, 2024
See description in zarr-developers/zarr-python#1143 Testing locally, however, does not suffice. In this case, the relative path in the test worked for me, but doesn't work on conda-forge. The only reliable way to be sure is to run `./build-locally.py` in the zarr-feedstock **against pre-tagged code**.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the pattern from #824, this generates the
fixture test if it does not exist so that tests will
pass on conda-forge.
see: conda-forge/zarr-feedstock#65
TODO: