Add FSStore contiguous bug fix note #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tidy release notes
Member
|
Thanks, @jakirkham! 🙏🏽 but the format looks a bit borked:
|
Member
Author
|
Unfortunately that entry already has issues Tried to fix some of them, but can back them out if that is distracting (it is tangential to this PR)
|
jakirkham
commented
Jan 19, 2023
jakirkham
commented
Jan 19, 2023
Member
Sorry. I just saw that myself. Didn't mean to offload it on you. |
jakirkham
commented
Jan 19, 2023
docs/release.rst
Outdated
Comment on lines
25
to
27
| - storage transformers | ||
|
|
||
| - ``get_partial_values`` and ``set_partial_values`` |
Member
Author
There was a problem hiding this comment.
So this looks ok in reStructuredText, but Sphinx seems to render it wacky. In any event at least this is consistent with what we do elsewhere
Member
Author
|
This is probably as good as we can get
https://zarr--1325.org.readthedocs.build/en/1325/release.html |
Member
Author
|
@joshmoore, could you please review when you have a chance? |
Member
|
Going to call this good. Merging. (@jstriebel can hit us on the head if he wants) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tidy release notes
xref: #1285 (comment)
cc @joshmoore @madsbk
TODO: