Skip to content

Enforce ruff/flake8-type-checking rules (TCH) #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dstansby merged 5 commits into from
Sep 6, 2024
Merged

Enforce ruff/flake8-type-checking rules (TCH) #2110

dstansby merged 5 commits into from
Sep 6, 2024

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Aug 23, 2024

https://docs.astral.sh/ruff/rules/#flake8-type-checking-tch

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review August 24, 2024 19:20
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the TCH branch 10 times, most recently from 8c848e0 to a551c84 Compare September 2, 2024 14:19
@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Sep 2, 2024 •
edited
Loading

Attempted to rebase, but something seems very wrong. I see conflicts between TCH rules and F821. It might be a ruff issue, I would like to upgrade to 0.6 before I start investigating.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft September 2, 2024 14:28
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Sep 2, 2024
Merged
6 tasks
@DimitriPapadopoulos
Apply ruff/flake8-type-checking rule TCH001
b4d0099 
TCH001 Move application import into a type-checking block
@DimitriPapadopoulos
Apply ruff/flake8-type-checking rule TCH002
9423a65 
TCH002 Move third-party import into a type-checking block
@DimitriPapadopoulos
Apply ruff/flake8-type-checking rule TCH003
c16793a 
TCH003 Move standard library import into a type-checking block
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review September 6, 2024 10:20
@dstansby dstansby merged commit c08b008 into zarr-developers:v3 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dstansby dstansby dstansby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DimitriPapadopoulos @dstansby