Skip to content

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Dec 4, 2018

In the ideal case, this cleanup step never happens on CI as the file got moved into place and so no longer exists at the old location. Given this, we ignore coverage on this line.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • Docs build locally (e.g., run tox -e docs)
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

In the ideal case, this cleanup step never happens on CI as the file got
moved into place and so no longer exists at the old location. Given
this, we ignore coverage on this line.
@jakirkham jakirkham mentioned this pull request Dec 4, 2018
7 tasks
@jakirkham jakirkham requested a review from alimanfoo December 4, 2018 15:11
@alimanfoo alimanfoo merged commit 6214948 into zarr-developers:master Dec 4, 2018
@alimanfoo alimanfoo added this to the v2.3 milestone Dec 4, 2018
@jakirkham jakirkham deleted the ignore_tempfile_cleanup branch December 4, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants