-
-
Notifications
You must be signed in to change notification settings - Fork 373
try to install azurite on github action #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Carreau - per your request, here's a smallish-public Zarr store on Azure: store = zarr.storage.ABSStore('carbonplan-share', prefix='zarr-demo', account_name='carbonplan')
zarr.open_consolidated(store) |
|
Thanks super useful, it seem that querying |
|
I wonder if #620 would fix the problem you are seeing with the empty string query. |
Possibly. I can have a look once we are back on track with testing. |
This should increase coverage.
This is due to azurite not allowing blob keys to be the empty string while azure seem to allow it.
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
==========================================
+ Coverage 98.38% 99.50% +1.11%
==========================================
Files 29 29
Lines 10118 10127 +9
==========================================
+ Hits 9955 10077 +122
+ Misses 163 50 -113
|
|
This increases coverage; and I've open 681 to track reverting the xfail commits. |
Again to get back to our 100% coverage.