Bump fsspec from 2021.6.0 to 2021.6.1

[dependabot]

Bumps fsspec from 2021.6.0 to 2021.6.1.

Commits

• 540a6f7 Merge pull request #676 from skshetry/find-less-isfile-calls
• a84d7fe Merge pull request #680 from jrbourbeau/entrypoints-select
• beade7f Merge pull request #679 from martindurant/mkdir_twice
• 2eb83d0 Do not ignote existing dir in local mkdir
• 1e85844 add tests
• 384b872 Update entrypoint selection
• 0c469bf Merge pull request #678 from d-v-b/sequential_rm
• 700ed8a LocalFileSystem support for a sequence of string arguments
• 66ee7d8 avoid isfile calls on find as much as possible
• c3dac4f Merge pull request #674 from martindurant/docs
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[joshmoore]

Well that's unexpected:

FAILED zarr/tests/test_core.py::TestArrayWithFSStoreNested::test_array_2d - A...
FAILED zarr/tests/test_core.py::TestArrayWithFSStoreNestedPartialRead::test_array_2d

[dependabot]

A newer version of fsspec exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

[grlee77]

This failure also occurs with fsspec 2021.7.0. It seems to be due to substition of '.' for '/' in nested filesystem keys:

From debug of zarr/tests/test_core.py::TestArrayWithFSStoreNested::test_array_2d:

(Pdb) z._store
<zarr.storage.FSStore object at 0x7ff592701700>
(Pdb) z._store.listdir()
['.0.0', '.0.1', '.0.2', '.0.3', '.0.4', '.1.0', '.1.1', '.1.2', '.1.3', '.1.4', '.2.0', '.2.1', '.2.2', '.2.3', '.2.4', '.3.0', '.3.1', '.3.2', '.3.3', '.3.4', '.4.0', '.4.1', '.4.2', '.4.3', '.4.4', '.5.0', '.5.1', '.5.2', '.5.3', '.5.4', '.6.0', '.6.1', '.6.2', '.6.3', '.6.4', '.7.0', '.7.1', '.7.2', '.7.3', '.7.4', '.8.0', '.8.1', '.8.2', '.8.3', '.8.4', '.9.0', '.9.1', '.9.2', '.9.3', '.9.4', '.zarray']

so /0/0 become .0.0 instead of 0.0
This causes it to not match the regular expression check when computing the number of chunks (expects patterns starting with a digit).

[joshmoore]

cc: @martindurant

[martindurant]

There was a change in fsspec that caused this?

[grlee77]

There was a change in fsspec that caused this?

It seems so. I get the two errors reported above locally if using fsspec 2021.6.1 or 2021.7.0, but not for 2021.6.0. With the change proposed in #802, it works for both the newer and older versions.

[martindurant]

We can release fsspec faster than zarr, so if there's a fix that should be made there, that might be preferable.

[grlee77]

I just ran git bisect and it points to this fsspec commit: fsspec/filesystem_spec@50e1ea0

[grlee77]

Within that commit, it is the addition of this rstrip call that makes things start failing on the Zarr side:

fsspec/filesystem_spec@50e1ea0#diff-b47117e431a1b37790be709fb84c0d854da5e73203e3de57ec6b6032b18eebf1R168

[martindurant]

Maybe because it affects the mapper's root at this line? But that line already did the same stripping.

[joshmoore]

Ok. Still seeing:

FAILED zarr/tests/test_core.py::TestArrayWithFSStoreNested::test_array_2d - A...
FAILED zarr/tests/test_core.py::TestArrayWithFSStoreNestedPartialRead::test_array_2d

with fsspec 2021.08.1 without #802. cc: @martindurant @grlee77

I'll go about getting #802 green and then I'd propose a release of it as 2.9.4 ASAP.

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.