Temporary PR for testing 773 and 793 #794
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous tests (now commented out) used logic in the store classes to convert "0/0" keys into "0.0" keys, forcing the store to be aware of array details. This tries to swap the logic so that stores are responsible for passing dimension separator values down to the arrays only. Since arrays can also get the dimension_separator value from a .zarray file they are now in charge.
Contributor
|
the doctest failures should be fixed if you want to rebase |
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
- Coverage 99.94% 99.67% -0.27%
==========================================
Files 30 31 +1
Lines 10586 10819 +233
==========================================
+ Hits 10580 10784 +204
- Misses 6 35 +29
|
Member
Author
|
My feeling is that this doesn't show any new issues, but I need to get my head back down in the state of @d-v-b's branch. Closing for the moment. |
This reverts commit 68adca5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests dimension_separator fixes on the new N5FSStore.
See #773 and #793