Skip to content

Circumvent Codecov's legitimate complaint without resorting to pragma #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshmoore merged 5 commits into from
Aug 25, 2021
Merged

Circumvent Codecov's legitimate complaint without resorting to pragma #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a660880
Circumvent Codecov's legitimate complaint
benjaminhwilliams Aug 24, 2021
f984c5e
Merge branch 'master' into cheat-codecov-fsspec
benjaminhwilliams Aug 24, 2021
e9a163d
Merge branch 'master' into cheat-codecov-fsspec
benjaminhwilliams Aug 24, 2021
f6c46d0
Add a release note
benjaminhwilliams Aug 24, 2021
b558e62
Correct typo
benjaminhwilliams Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/release.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ Release notes
Unreleased
----------

Maintenance
~~~~~~~~~~~

* Mark the fact that some tests that require ``fsspec``, without compromising the code coverage score.
By :user:`Ben Williams <benjaminhwilliams>`; :issue:`823`.

.. _release_2.9.2:

2.9.2
Expand Down
13 changes: 7 additions & 6 deletions zarr/tests/test_dim_separator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,19 @@
from zarr.tests.util import have_fsspec


needs_fsspec = pytest.mark.skipif(not have_fsspec, reason="needs fsspec")


@pytest.fixture(params=("static_nested",
"static_flat",
"directory_nested",
"directory_flat",
"directory_default",
"nesteddirectory_nested",
"nesteddirectory_default",
"fs_nested",
"fs_flat",
"fs_default"))
pytest.param("fs_nested", marks=needs_fsspec),
pytest.param("fs_flat", marks=needs_fsspec),
pytest.param("fs_default", marks=needs_fsspec)))
def dataset(tmpdir, request):
"""
Generate a variety of different Zarrs using
Expand All @@ -42,8 +45,6 @@ def dataset(tmpdir, request):
elif which.startswith("nested"):
store_class = NestedDirectoryStore
else:
if have_fsspec is False:
pytest.skip("no fsspec") # pragma: no cover
store_class = FSStore
kwargs["mode"] = "w"
kwargs["auto_mkdir"] = True
Expand All @@ -66,7 +67,7 @@ def test_open(dataset):
verify(zarr.open(dataset, "r"))


@pytest.mark.skipif(have_fsspec is False, reason="needs fsspec")
@needs_fsspec
def test_fsstore(dataset):
verify(Array(store=FSStore(dataset)))

Expand Down