Consistent signatures for listdir() and rmdir()

[DimitriPapadopoulos]

Fixes #890.

TODO:

• Add unit tests and/or doctests in docstrings
• Add docstrings and API docs for any new/modified user-facing classes and functions
• New/modified features documented in docs/tutorial.rst
• Changes documented in docs/release.rst
• GitHub Actions have all passed
• Test coverage is 100% (Codecov passes)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (f0677c2) to head (86ea815).
Report is 465 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #903   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          32       32           
  Lines       11218    11218           
=======================================
  Hits        11212    11212           
  Misses          6        6           

Files with missing lines	Coverage Δ
zarr/_storage/store.py	100.00% <100.00%> (ø)
zarr/storage.py	100.00% <100.00%> (ø)

[DimitriPapadopoulos]

It works by changing the type of the path argument from Path = Union[str, bytes, None] to str everywhere. I suspect bytes is obsolete/not required, and I believe None can be implicit.

[joshmoore]

Few thoughts, but this one may need a few more eyes on it.

[joshmoore]

Why did this need to shift down?

[DimitriPapadopoulos]

It's just the order used everywhere else in the code: 1) listdir 2) rmdir

[joshmoore]

Might need some comparison to #768

[DimitriPapadopoulos]

I had a look at #768:

• I understand it would be nice if path could be PathLike in addition to str, wouldn't it?
• BTW, I would rename _might_close() to _is_path_like(), it's easier to understand because that's really what the function is about.

[jhamman]

I'm going to close this as stale. Folks should feel free to reopen if there is interest in continuing this work but understand that the Store API has changed significantly in v3.