Skip to content

merge from master #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zburning merged 5 commits into from
Oct 29, 2019
Merged

merge from master #2

zburning merged 5 commits into from
Oct 29, 2019

Conversation

@zburning
Copy link
Owner

@zburning zburning commented Oct 29, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

emilmont and others added 5 commits October 24, 2019 22:01
@emilmont @leezu
[FEATURE] Add raw attention scores to the AttentionCell #951 (#964)
06ecac8 
* Implement: Add raw attention scores to the AttentionCell #951

* Fix pylint issues.

* Address code-review comments.

* Separate _compute_score form _compute_weight.
@leezu
[CI] Enable testing warnings with pytest and update deprecated API in…
7c4fd12 
…vocations (#980)

Test changes
- Enforce that no unexpected warnings are thrown.

API changes
- Update gluonnlp.data.UnigramCandidateSampler to make use of MXNet random.uniform_like operator and drop constructor shape argument. Now the candidates_like argument during forward is used to specify shape of to be sampled candidates. This was the originally intended design, but had to wait for MXNet random.uniform_like operator being available in stable MXNet.
@leezu
Improve Vocab.__repr__ if reserved_tokens or unknown_token is None (#989
e746ba1 
)
@szha
bump version in preparation for 0.9 release (#987)
dfd4c6d
@leezu @szha
[CI] Use Cuda 10.0 MXNet build (#991)
bfa5503 
* Update MXNet dependency to cu100-1.6.0b20191027 for CPU and GPU

Nightly release pipelines for cu101-mkl is currently blocked.
Recent CPU builds also failed.

* Simplify Dockerfile

* Fix lint
@zburning zburning merged commit f49b536 into zburning:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zburning @emilmont @leezu @szha