Skip to content

Improve Tracers module weapon compatibility #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mharis001 merged 1 commit into from
Jul 10, 2021
Merged

Improve Tracers module weapon compatibility #604

mharis001 merged 1 commit into from
Jul 10, 2021

Conversation

@mharis001
Copy link
Member

@mharis001 mharis001 commented Jun 26, 2021

When merged this pull request will:

  • Use BIS_fnc_baseWeapon for better base weapon support
    • Some weapons do not have baseWeapon config entry explicitly defined
  • Filter out SAFE muzzle (generally found in RHS weapons)

@mharis001 mharis001 added the enhancement Improves an existing feature label Jun 26, 2021
@mharis001 mharis001 added this to the 1.12.0 milestone Jun 26, 2021
CreepPork
CreepPork approved these changes Jun 27, 2021
View reviewed changes
Copy link
Member

@CreepPork CreepPork left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this to 1.11.1?

@jonpas
Copy link
Contributor

jonpas commented Jun 27, 2021

There is also https://github.com/CBATeam/CBA_A3/blob/da4539095ca62836c555b38523918a1c36e9eb1a/addons/common/fnc_getNonPresetClass.sqf in case it would work better (uses https://github.com/CBATeam/CBA_A3/blob/da4539095ca62836c555b38523918a1c36e9eb1a/addons/common/fnc_weaponComponents.sqf for weapons). No clue which is more reliable and/or faster at this point though.

@mharis001
Copy link
Member Author

mharis001 commented Jun 29, 2021

BIS_fnc_baseWeapon works well for this. This is what BI Arsenal, ACE Arsenal, and the inventory display use. Also, The CBA functions can't be used at preStart due to creating namespaces.

@mharis001 mharis001 merged commit 68af186 into master Jul 10, 2021
@mharis001 mharis001 deleted the tracers-weapon-compat branch July 10, 2021 20:42
@mharis001 mharis001 modified the milestones: 1.12.0, 1.11.1 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CreepPork CreepPork CreepPork approved these changes

@neilzar neilzar neilzar approved these changes

Assignees

No one assigned

Labels

enhancement Improves an existing feature

Projects

None yet

Milestone

1.11.1

Development

Successfully merging this pull request may close these issues.

5 participants

@mharis001 @jonpas @CreepPork @neilzar