This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Fixed typo in variable name #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michalbundyra
left a comment
michalbundyra
left a comment
There was a problem hiding this comment.
It would be nice to add test case :)
Contributor
Author
|
@webimpress You're right, this would've been caught if there was a test case that passes an empty array for tags. I'm off today, but I'll add a test case this evening or tomorrow for this. Off topic: I made a Redis adapter that supports tags for one of our projects. Should I make a PR? |
Member
|
@ptodorov0123
Cool, thanks 👍
Sure, create PR 😄 |
… setTags clears the tags
weierophinney
added a commit
that referenced
this pull request
May 1, 2018
weierophinney
added a commit
that referenced
this pull request
May 1, 2018
weierophinney
added a commit
that referenced
this pull request
May 1, 2018
Forward port #168 Conflicts: CHANGELOG.md
Member
|
Thanks, @ptodorov0123! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo in setTags in the filesystem adapter.