-
Notifications
You must be signed in to change notification settings - Fork 52
Issue #185 : replacing deprecated delete() calls with del() #186
Conversation
|
@ppaulis Please see PR I've created to your branch: http://github.com/ppaulis/zend-cache/pull/1 |
|
@ppaulis , @webimpress please prepare and push these changes to release |
|
@webimpress i dont really think this is an enhancement but a bug which is blocking a lot nowadays? |
|
Not a bug: needs to indeed land in a new minor, since we are adding compatibility with a new tool, not fixing a bug here. |
Ocramius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would most likely need an addition of "conflicts": {"ext-redis": "<5.0.0"} (or a matching version that has the del() API) in composer.json
|
As @boesing checked del() is available since 2.1.0 release. Ref:
and the latest version available on PECL is 2.2.3: There is no need to add any conflict. |
PHP 5.6: - 2.2.3 - 3.1.6 - 4.3.0 PHP 7.0-7.2: - 4.0.0 - 5.0.0 - 5.0.2
Issue #185 : replacing deprecated delete() calls with del()
|
Thanks, @ppaulis! |
Fixing Issue #185
Since redis extension 5.0.0, Deprecation errors are thrown on every Redis::delete() call.
Replacing the delete() calls with del() calls fixes these messages.