This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Escape "$" in toolbar content #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used as replacement targets by preg_replace()
weierophinney
added a commit
that referenced
this pull request
Apr 17, 2018
…oller_numeric_in_toolbar Escape "$" in toolbar content
weierophinney
added a commit
that referenced
this pull request
Apr 17, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 17, 2018
Member
|
Thanks, @MatthiasKuehneEllerhold! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to display the string "$1", "$2" or any numeric after a dollar sign in the toolbar content and it failed. It just got filtered out by the toolbar listener.
After debugging I found the culprit in the ToolbarListener: preg_replace uses $0 .. $99 as replacement targets.
Escaping all "$" prior to the preg_replace call fixes that.