This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Use lowercase config key to get configuration from container
#259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michalbundyra
commented
Oct 21, 2019
michalbundyra
commented
- Is this related to quality assurance?
froschdesign
approved these changes
Oct 22, 2019
Member
froschdesign
left a comment
froschdesign
left a comment
There was a problem hiding this comment.
The same here: I think we follow the lowercase notation in all packages and this pull requests preserves the consistency. (See: zendframework/zend-config#66)
weierophinney
added a commit
that referenced
this pull request
Dec 26, 2019
Use lowercase `config` key to get configuration from container
weierophinney
added a commit
that referenced
this pull request
Dec 26, 2019
weierophinney
added a commit
that referenced
this pull request
Dec 26, 2019
Forward port #259 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.