fix minor issues in the nest.js v3 docs, switch to SQLite#532
fix minor issues in the nest.js v3 docs, switch to SQLite#532ymc9 merged 1 commit intozenstackhq:mainfrom
Conversation
|
@lsmith77 is attempting to deploy a commit to the ZenStack Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughReworks NestJS recipe docs: replaces PostgreSQL dialect with SqliteDialect and a SQLite DB in samples; updates file path annotations and import paths to use Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
versioned_docs/version-3.x/recipe/nestjs.md (2)
47-60: Fix incorrect import path on line 49.The import path
'./db.service'is inconsistent with the file structure. Since DbService is located atsrc/db/db.service.ts, the correct import fromsrc/app.controller.tsshould be'./db/db.service'. This matches the import path used in the AppModule (line 36) and the CRUD example (line 134).🔎 Proposed fix
import { Controller, Get } from '@nestjs/common'; - import { DbService } from './db.service'; + import { DbService } from './db/db.service';
109-124: Fix incorrect import path on line 111.The import path
'./db.service'is inconsistent with the file structure. Since DbService is located atsrc/db/db.service.ts, the correct import fromsrc/app.controller.tsshould be'./db/db.service'. This matches the import path used in the access-controlled AppModule (line 71) and the CRUD example (line 134).🔎 Proposed fix
import { Controller, Get, Inject } from '@nestjs/common'; - import { DbService } from './db.service'; + import { DbService } from './db/db.service';
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
versioned_docs/version-3.x/recipe/nestjs.md(4 hunks)
🔇 Additional comments (3)
versioned_docs/version-3.x/recipe/nestjs.md (3)
13-43: SQLite migration and module setup look good.The DbService correctly switches to
SqliteDialectwithbetter-sqlite3, and the AppModule properly registers it as a provider with correct import paths.
68-105: Access-controlled module setup is correct.The AppModule properly registers both the standard and access-controlled DbService instances, with correct imports and the explicit
export class AppModule {}declaration.
130-168: CRUD API handler example is well-structured.The import paths are correct (
'./db/db.service'and'../zenstack/schema'), and the example properly demonstrates injecting the access-controlled DbService and initializing the RestApiHandler with the schema.
e99836f to
a6b149c
Compare
If you prefer I can keep PostgreSQL but I think SQLite makes it easier for people to get this setup quickly. How to deal with PostgreSQL is then handled elsewhere in the docs.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.