Conversation
Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>
* fix(tanstack): build OOM type fix
* use Record<never, never> instead of {} for ProcedureHooks type
fixes #610
|
Claude finished @ymc9's task —— View job PR Review Complete ✅I've completed my review of this version bump PR (dev → main, v3.3.2). Here's my analysis: ✅ Code Quality & Best Practices
📝 Key Changes Reviewed1. Version Bumps (27 files)
2. TanStack Query Type Fix (Issue #610)
✅ Technical AssessmentPerformance: The type changes are specifically designed to resolve build OOM issues - this is a performance improvement ✓ Security: No security concerns identified - this is purely version bumps + type fixes ✓ Compatibility:
✅ Release Process Quality
🔍 Minor Observations
✅ RecommendationAPPROVE - This is a well-structured release PR with:
The OOM type fix is particularly valuable as build performance issues can significantly impact developer experience. Review checklist completed:
|
📝 WalkthroughWalkthroughThe pull request bumps version numbers from 3.3.1 to 3.3.2 across 22 package.json files in the monorepo. Additionally, three source files in the tanstack-query package refine the ProcedureHooks type's conditional logic to check Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR merges development changes to main for version 3.3.2, including a version bump across all packages and an important TypeScript type safety improvement in the tanstack-query client.
Changes:
- Version bump from 3.3.1 to 3.3.2 across all 27 package.json files
- Improved TypeScript type checking for
ProcedureHooksto correctly handle optional procedures field using indexed access types - Changed empty object type from
{}toRecord<never, never>for better type safety
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Root package version updated to 3.3.2 |
| packages/auth-adapters/better-auth/package.json | Version bump to 3.3.2 |
| packages/cli/package.json | Version bump to 3.3.2 |
| packages/clients/client-helpers/package.json | Version bump to 3.3.2 |
| packages/clients/tanstack-query/package.json | Version bump to 3.3.2 |
| packages/clients/tanstack-query/src/react.ts | Improved type safety for ProcedureHooks with indexed access and Record<never, never> |
| packages/clients/tanstack-query/src/svelte/index.svelte.ts | Improved type safety for ProcedureHooks with indexed access and Record<never, never> |
| packages/clients/tanstack-query/src/vue.ts | Improved type safety for ProcedureHooks with indexed access and Record<never, never> |
| packages/common-helpers/package.json | Version bump to 3.3.2 |
| packages/config/eslint-config/package.json | Version bump to 3.3.2 |
| packages/config/typescript-config/package.json | Version bump to 3.3.2 |
| packages/config/vitest-config/package.json | Version bump to 3.3.2 |
| packages/create-zenstack/package.json | Version bump to 3.3.2 |
| packages/ide/vscode/package.json | Version bump to 3.3.2 |
| packages/language/package.json | Version bump to 3.3.2 |
| packages/orm/package.json | Version bump to 3.3.2 |
| packages/plugins/policy/package.json | Version bump to 3.3.2 |
| packages/schema/package.json | Version bump to 3.3.2 |
| packages/sdk/package.json | Version bump to 3.3.2 |
| packages/server/package.json | Version bump to 3.3.2 |
| packages/testtools/package.json | Version bump to 3.3.2 |
| packages/zod/package.json | Version bump to 3.3.2 |
| samples/orm/package.json | Version bump to 3.3.2 |
| tests/e2e/package.json | Version bump to 3.3.2 |
| tests/regression/package.json | Version bump to 3.3.2 |
| tests/runtimes/bun/package.json | Version bump to 3.3.2 |
| tests/runtimes/edge-runtime/package.json | Version bump to 3.3.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.