fix: zenstack cli errors while using bun/bunx during docker build#1011
Merged
ymc9 merged 9 commits intozenstackhq:devfrom Feb 19, 2024
Merged
fix: zenstack cli errors while using bun/bunx during docker build#1011ymc9 merged 9 commits intozenstackhq:devfrom
ymc9 merged 9 commits intozenstackhq:devfrom
Conversation
This reverts commit 42ffcf6.
ymc9
reviewed
Feb 19, 2024
Member
|
Thank you for working on this @ErikMCM ! |
ymc9
approved these changes
Feb 19, 2024
This was referenced Mar 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's an obscure issue but it exists in my CI pipeline.
This PR attempts to fix the error that occurs when the following criteria are met:
pretty-replwhich subsequently requiresreplwhich is not supported by the Bun runtime at this timeThis PR fixes the error by:
pretty-replafter checking if the runtime is bun and in a non-TTY terminalzenstack generatecommandThis PR could be reverted once Bun REPL support is fully implemented, allowing the
zenstack replcommand to be used in such a case. However, considering the current support for REPL on Bun is still experimental, it may be some time before it is resolved.