fix: post-update rule for id field is not effective if id is updated

[ymc9]

Fixes #1235

[coderabbitai]

Walkthrough

Walkthrough

The recent changes primarily focus on enhancing the functionality for creating multiple records in both Post and User routers, refining policy enforcement, and updating expression handling in policy-related classes. These updates improve input validation, mutation logic, and policy checks, ensuring more robust and flexible server-side operations.

Changes

File Path	Change Summary
.../routers/Post.router.ts .../routers/User.router.ts	Added createMany procedures with input validation and mutation logic.
.../policy/handler.ts	Updated _registerPostUpdateCheck function with new parameters for better post-update checks.
.../access-policy/expression-writer.ts .../access-policy/policy-guard-generator.ts .../utils/typescript-expression-transformer.ts	Enhanced handling of expressions and context in policy enforcement.
tests/integration/tests/regression/issue-1235.test.ts	Added tests for schema loading and policy enforcement related to updating posts.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure createMany procedures handle input validation and mutation logic efficiently (#1235)	✅
Refine policy checks for update operations in the context of @@deny and @@allow (#1235)	✅
Address the bug in update permission when used in @@deny (#1235)	✅
Resolve issues with expression handling in policy enforcement (#1235)	✅

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6ffc3e7 and 91d8218.

Files selected for processing (1)

• packages/schema/src/plugins/access-policy/policy-guard-generator.ts (5 hunks)

Files skipped from review as they are similar to previous changes (1)

• packages/schema/src/plugins/access-policy/policy-guard-generator.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2