fix: issue with auth() in @default accidentally overrides "connect"

[ymc9]

@default with auth() shouldn't be effective if it's on a foreign key and the user provides an explicit value for the relation.

Summary by CodeRabbit

• New Features
  • Enhanced authentication handling to preserve existing foreign key relationships in certain scenarios.
• Tests
  • Updated integration tests to accommodate new email fields in the User model and revised expectations for post creations.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve enhancing the DefaultAuthHandler to prevent overwriting existing foreign key relations and updating the testing framework to accommodate new user model fields. These modifications aim to improve data integrity and testing robustness in the application.

Changes

Files	Change Summary
.../default-auth.ts	Added check to avoid overriding set relation fields in foreign keys.
.../tests/enhancements/with-policy/auth.test.ts	Updated to destructure prisma, added email fields to User model, revised user creation and post expectations in tests.

Possibly related issues

• Zenstack does not let me define multiple fields that are referencing the same model #653: The changes in handling relations in DefaultAuthHandler could relate to ensuring proper referencing and validation of multiple fields to the same model, addressing some concerns of issue Zenstack does not let me define multiple fields that are referencing the same model #653 about model relationships.

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 81c7e87 and 5468270.

Files selected for processing (2)

• packages/runtime/src/enhancements/default-auth.ts (1 hunks)
• tests/integration/tests/enhancements/with-policy/auth.test.ts (2 hunks)

Additional comments not posted (2)

packages/runtime/src/enhancements/default-auth.ts (1)

95-98: Ensure that the new conditional logic correctly prevents overriding of explicitly set foreign keys.

tests/integration/tests/enhancements/with-policy/auth.test.ts (1)

439-461: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [420-458]

Validate the updated test cases to ensure they correctly reflect the new behavior regarding default authorization and foreign keys.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.