Skip to content

chore: format generated PLS automatically by default#1253

Merged
ymc9 merged 2 commits intov2from
chore/format-pls-by-default
Apr 14, 2024
Merged

chore: format generated PLS automatically by default#1253
ymc9 merged 2 commits intov2from
chore/format-pls-by-default

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Apr 14, 2024

Summary by CodeRabbit

  • Refactor
    • Improved the condition for executing formatting commands based on user settings.
  • New Features
    • Added a new plugin prisma with provider @core/prisma.
    • Included format: false property in multiple configurations for schema generation.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 14, 2024

Walkthrough

Walkthrough

The recent updates focus on refining the behavior of a schema generator tool in a Prisma plugin. These changes enhance the execution logic of the formatting command by considering the options.format value. Now, the command will only run if options.format is not explicitly set to false, providing more precise control over schema generation formatting.

Changes

File Path Change Summary
packages/schema/src/plugins/prisma/schema-generator.ts Modified the condition for running the formatting command based on the options.format value.
packages/schema/tests/generator/prisma-generator.test.ts Added a new plugin prisma with provider @core/prisma. Added format: false property in multiple configurations for schema generation.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ddb6b1d and 58edd32.
Files selected for processing (1)
  • packages/schema/tests/generator/prisma-generator.test.ts (4 hunks)
Additional comments not posted (3)
packages/schema/tests/generator/prisma-generator.test.ts (3)

47-49: The addition of the new plugin prisma with provider @core/prisma is correctly implemented. This aligns with the PR's objective to enhance the Prisma schema generator's capabilities.


63-63: The explicit setting of format: false in the schema generation configuration ensures that formatting is disabled as intended. This change is consistent with the PR's objective to manage formatting settings more explicitly.


105-105: Again, setting format: false in this additional test configuration is consistent with the intended behavior of allowing explicit control over formatting. This ensures that the generator behaves as expected in different test scenarios.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ymc9 ymc9 merged commit b702a10 into v2 Apr 14, 2024
@ymc9 ymc9 deleted the chore/format-pls-by-default branch April 14, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant