fix: policy compilation error for deeply nested post-update rules

[ymc9]

Summary by CodeRabbit

• New Features

  • Enhanced the handling of non-member access expressions in the ExpressionWriter.

• Tests

  • Added integration test for nested model updates with policy conditions.
  • Introduced regression test for schema loading and field update authorizations.

[ymc9]

Fixes #1381

[coderabbitai]

Walkthrough

Walkthrough

The recent updates focus on enhancing the robustness and testing of the system. The ExpressionWriter class now better handles non-MemberAccessExpr scenarios through recursive checks. Additionally, integration and regression tests have been expanded. New test scenarios cover deep-nested updates in collections with policy enforcement and address specific schema loading issues identified in earlier versions.

Changes

File Path	Summary of Changes
packages/schema/.../expression-writer.ts	Updated isFutureMemberAccess in ExpressionWriter to recursively handle cases where operand is not MemberAccessExpr.
tests/integration/.../post-update.test.ts	Added test for deep-nested post-update scenarios in collections with nested models M1, M2, and M3 and policy checks.
tests/regression/.../issue-1381.test.ts	Introduced a test for issue 1381 focusing on schema loading with detailed model definitions and authorization rules.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 54c4bd5 and 4b60b53.

Files ignored due to path filters (2)

• packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/routers/Post.router.ts is excluded by !**/generated/**
• packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/routers/User.router.ts is excluded by !**/generated/**

Files selected for processing (3)

• packages/schema/src/plugins/enhancer/policy/expression-writer.ts (1 hunks)
• tests/integration/tests/enhancements/with-policy/post-update.test.ts (1 hunks)
• tests/regression/tests/issue-1381.test.ts (1 hunks)

Additional comments not posted (4)

tests/regression/tests/issue-1381.test.ts (2)

1-1: Ensure that the import from @zenstackhq/testtools is used correctly in the test setup.

---

3-61: The regression test setup appears comprehensive and correctly models the relationships and policy rules as described. Ensure that the test cases cover all scenarios related to the issue #1381.

tests/integration/tests/enhancements/with-policy/post-update.test.ts (1)

240-303: The new test case for deep-nested post-update conditions appears to be correctly set up. Ensure that the policy rules are enforced as expected and that the test assertions accurately reflect the intended behavior.

packages/schema/src/plugins/enhancer/policy/expression-writer.ts (1)

466-474: The updated isFutureMemberAccess method now correctly handles recursive checks for future expressions. This change is crucial for supporting deeply nested expressions in policy rules.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.