fix: compatibility with pnpm monorepo

[ymc9]

• Use @zenstackhq/runtime/models to import logical prisma client types
• Except for zod plugin, when generating into default location, still use ".zenstack/models" to avoid cyclic dependencies
• Only run prisma client generator when generating for logical schema

[coderabbitai]

Walkthrough

Walkthrough

The updates across various files in the packages/schema/src/plugins directory focus on enhancing import handling, refining Prisma client generation, and adjusting for better compatibility and error management in different environments, particularly focusing on ZenStack's integration with Prisma.

Changes

File Path	Change Summary
.../enhancer/enhance/index.ts	Enhanced Prisma schema and client generation logic, added imports, updated constants and error handling.
.../enhancer/index.ts	Updated import paths and modified how prismaClientPath is assigned.
.../zod/generator.ts	Added new function to adjust Prisma client import path, updated imports.
.../zod/transformer.ts	Replaced an import to use a newly added function from generator.ts.

Possibly related issues

• Issue Can't resolve '@prisma/client/runtime' in pnpm monorepo #944: The updates in Prisma client path handling could potentially resolve the path resolution error mentioned in this issue.
• Issue Zenstack does not let me define multiple fields that are referencing the same model #653: The changes in Prisma schema generation might address the issue of referencing the same model multiple times within a model, as seen in this issue.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ef22b70 and 892c2b5.

Files selected for processing (4)

• packages/schema/src/plugins/enhancer/enhance/index.ts (5 hunks)
• packages/schema/src/plugins/enhancer/index.ts (2 hunks)
• packages/schema/src/plugins/zod/generator.ts (3 hunks)
• packages/schema/src/plugins/zod/transformer.ts (2 hunks)

Additional comments not posted (7)

packages/schema/src/plugins/enhancer/index.ts (1)

34-34: Standardized Prisma client path using RUNTIME_PACKAGE.

packages/schema/src/plugins/zod/generator.ts (2)

4-4: Introduced RUNTIME_PACKAGE to standardize import paths.

---

586-595: Added computePrismaClientImport to dynamically adjust Prisma client import paths based on conditions.

packages/schema/src/plugins/enhancer/enhance/index.ts (2)

48-48: Introduced LOGICAL_CLIENT_GENERATION_PATH to standardize the directory path for logical Prisma client generation.

---

68-68: Updated logic to handle logical Prisma client generation, ensuring compatibility and standardization.

packages/schema/src/plugins/zod/transformer.ts (2)

8-8: Import of computePrismaClientImport correctly added to dynamically adjust Prisma client import paths.

---

294-294: Modification to generateImportPrismaStatement correctly implements dynamic Prisma client import path resolution.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.